Various tracker module features #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe a uniform naming scheme should be used for these module features, I'm open to suggestions. |
|
LGTM. More than OK with merging partial work in this repo. |
|
My only suggestion would be maybe to add a |
|
I'm sorry perhaps you didn't intended this to be merged now? |
|
It's okay I'll just make a PR later with the last stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small untested change that adds the various tracker seeking/telling features I wanted in #15, it's still incomplete but supports most of it.
Only need to figure out how to calculate the sample length of an XM pattern, then it's fully done.
Currently here's how support looks
* = Untested
I've taken some reference from http://lclevy.free.fr/mo3/mod.txt when it comes to implementing samplesRemainingInPattern for MOD files.